On 2013/08/21 10:01:53, Sven Panne wrote:
On 2013/08/20 17:05:40, Michael Starzinger wrote:
> [...]
> - SetDataProperty(), for normal data properties taking HValue
> - SetNativeProperty(), for data properties using
Accessor[G/S]etterCallback
> - SetAccessorProperty(), for JavaScript accessors
I would prefer having "Data" somehow in the 2nd version, e.g.
"SetNativeDataProperty" or perhaps just overloading things via
"SetDataProperty". From the signature is blindingly obvious that it is
using
some kind of callback mechanism, but it is highly unclear that this
results in
a
*data* property.
I strongly dislike the overloading -- it may be blindingly clear from
reading
the _signature_, but not from reading random _code_ that uses it. I can
certainly live with SetNativeDataProperty, too, though it sounds a bit
verbose
(and their won't ever be native accessor properties).
https://codereview.chromium.org/23182003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
