LGTM.
https://codereview.chromium.org/23182003/diff/27001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/23182003/diff/27001/src/factory.cc#newcode1536
src/factory.cc:1536: Handle<AccessorInfo> accessor(value, isolate());
nit: This can be simplified to just ...
Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i)));
https://codereview.chromium.org/23182003/diff/27001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23182003/diff/27001/src/objects.h#newcode9529
src/objects.h:9529: static int AppendUnique(Handle<Object> descriptors,
nit: Can we have a short one-liner comment describing this method?
https://codereview.chromium.org/23182003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
