Next round of comments. BTW: I'm not sure if "make grokdump" is needed to
update
tools/v8heapconst.py.
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc#newcode3135
src/objects.cc:3135: static bool InsertUnique(Name* key,
Splitting InsertUnique into 2 methods
Contains(key,valid_descriptors,array)
Insert(key,entry,valid_descriptors,array)
makes it a bit clearer what's going on.
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc#newcode3158
src/objects.cc:3158: array->set(valid_descriptors, entry);
Why is there always room for the new entry?
https://codereview.chromium.org/23182003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
