Adding Michael, we talked about this yesterday. In general this looks OK,
but it
is of course only the threading of a flag. It would be nice to see a CL
building
on this one where the new predicate is actually used (plus some hints where
it
might be used, too).
The change as it is isolates things a bit, but the new flag is still "a
kind of
magic". (Queen pun intended ;-)
https://chromiumcodereview.appspot.com/23464022/diff/1/src/isolate.h
File src/isolate.h (right):
https://chromiumcodereview.appspot.com/23464022/diff/1/src/isolate.h#newcode1141
src/isolate.h:1141: bool isMemoryConstrained() {
On 2013/09/03 19:39:18, tfarina wrote:
I believe this should be is_memory_constrained()
... and should be const.
https://chromiumcodereview.appspot.com/23464022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
