On 2013/09/05 15:36:39, rmcilroy wrote:
Thanks Sven. I've had to slightly change the API to take a pointer to a
boolean
so that the setResourceConstraints will not re-set is_memory_constrained
if
the
ResourceConstraint being passed didn't have a call to
set_memory_constrained
(e.g., treat the value as either do-nothing, set to true or set to
false). I
had to do this because this will be called by both Chrome code and Blink
code,
so I need to have a "do nothing" option to avoid Chrome setting it to
true,
and
blink accidentally setting back to the default of false.
PTAL. If you are happy with it could you please land it for me (I'm not
a V8
committer yet).
NOT LGTM. The plan regarding Isolates and ResourceConstraints is that there
will
be exactly one way to create an Isolate (no default Isolate anymore) via
some
constructor or factory method, and this constructor/factory will get
optional
ResourceConstraints (or something similar). Therefore there should be
exactly
*one* place to construct ResourceConstraints, and you should basically view
them
as immutable. Put another way: ResourceConstraints are just additional
arguments
to the Isolate constructor/factory, i.e. it's an argument object.
Perhaps I misunderstood things, so we should clarify this tomorrow or next
week,
but giving out a pointer to parts of that argument object seems
fundamentally
wrong.
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
