On Fri, Sep 13, 2013 at 11:30 AM, <[email protected]> wrote: > On 2013/09/13 06:24:25, Sven Panne wrote: > >> On 2013/09/12 18:16:24, Hannes Payer wrote: >> > All right, the patch looks fine. But I don't think we should do it for >> > non-memory-constrained devices, at least not now. Can we turn it on/off >> > based > >> on >> > such a memoy-constrained device check? Moreover it would be nice to >> turn it >> > on/off using on a command line flag. >> > > This is what Isolate::is_memory_**constrained() is for... >> > > Yes, I can use Isolate::is_memory_**constrained() to disable this for > non-memory-constrained devices. Do you also want me to put it behind a > flag? > If so, is this flag something you want to be able to turn it on for > non-memory-constrained devices, or to turn it off for all devices?
What about this: Add a flag --memory-constrained (or perhaps a better name a native speaker likes more, it's up to you :-) defaulting to false (i.e. --no-memory-constrained) which sets the initial value of is_memory_constrained for Isolate. If ResourceConstraints contain the respective flag, it overrides the command line flag on a per-Isolate basis. This way things are unchanged per default, you can test the new stuff via "d8 --memory-constrained" and Chrome can still set this per-Isolate. Hannes, would this be OK? -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
