On 2013/09/13 09:56:40, Hannes Payer wrote:
On 2013/09/13 09:30:50, rmcilroy_google wrote:
> On 2013/09/13 06:24:25, Sven Panne wrote:
> > On 2013/09/12 18:16:24, Hannes Payer wrote:
> > > All right, the patch looks fine. But I don't think we should do it
for
> > > non-memory-constrained devices, at least not now. Can we turn it
on/off
> based
> > on
> > > such a memoy-constrained device check? Moreover it would be nice to
turn
it
> > > on/off using on a command line flag.
> >
> > This is what Isolate::is_memory_constrained() is for...
>
> Yes, I can use Isolate::is_memory_constrained() to disable this for
> non-memory-constrained devices. Do you also want me to put it behind a
flag?
> If so, is this flag something you want to be able to turn it on for
> non-memory-constrained devices, or to turn it off for all devices?
It would be funky to overrule Isolate::is_memory_constrained() to
experiment
with this feature if needed.
I'm assuming "funky" here means it would be good ;). I've updated this CL
to
only pre-age for memory_constrained devices. I'll send another CL for
adding
the command line flag to set is_memory_constrained.
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
