Drive-by comment.
https://codereview.chromium.org/23480031/diff/65001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/23480031/diff/65001/src/ia32/full-codegen-ia32.cc#newcode166
src/ia32/full-codegen-ia32.cc:166: __ nop();
IIUC this is a glorified way to store exactly one bit of information,
namely whether a code object is freshly generated and has never been
aged before. Wouldn't it be easier to store that bit of information in
the code object header? This could spare us from adding a NOP to every
single method prologue. Also it would keep platform specific changes to
a minimum.
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
