NOT LGTM. I really don't like the conditional changes in the prologue. I am
pretty sure that you use a bit in the code object for the information you
need
and rely off the execution of the age stub to increment it, rather than
adding a
noop to all code, even non-constrained code. Here's how I'd make this
change:
on execution --> go back to young, but increment a counter on the code
object.
Only needs to be 2 bits, but not in instruction stream.
When you age code, go directly to "old" if the execution count is only 1. If
it's pinned at the max value, go through the old aging algorithm.
Also, please split this into 2 CLs, one for the resource management
framework
and one for the actual code aging.
BTW, for resource constrained systems, why not just reduce the number of
GCs to
one to reclaim code in general?
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
