LGTM with comments.
https://codereview.chromium.org/23567003/diff/4001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/23567003/diff/4001/src/code-stubs-hydrogen.cc#newcode481
src/code-stubs-hydrogen.cc:481:
isolate()->heap()->empty_fixed_array()));
nit: Let's drop this assert, see comment below.
https://codereview.chromium.org/23567003/diff/4001/src/code-stubs-hydrogen.cc#newcode488
src/code-stubs-hydrogen.cc:488: store->SkipWriteBarrier();
We should just add the empty fixed array to the list of immortal
immovable objects and not worry about WBs here. The graph builder should
not need to think about WBs.
https://codereview.chromium.org/23567003/diff/4001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/23567003/diff/4001/src/objects-inl.h#newcode1324
src/objects-inl.h:1324:
nit: Two empty newlines.
https://codereview.chromium.org/23567003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
