LGTM, after talking offline.
https://codereview.chromium.org/23567003/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/23567003/diff/1/src/code-stubs-hydrogen.cc#newcode470
src/code-stubs-hydrogen.cc:470:
isolate()->heap()->empty_fixed_array()));
This assert can go, empty fixed array is always in old space.
https://codereview.chromium.org/23567003/diff/1/src/code-stubs-hydrogen.cc#newcode476
src/code-stubs-hydrogen.cc:476: // empty fixed array be an "immortal
immovable?"
The write barrier should be skipped there by default. We can verify if
you like?
https://codereview.chromium.org/23567003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
