thx yall, checking in...
https://codereview.chromium.org/23567003/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/23567003/diff/1/src/code-stubs-hydrogen.cc#newcode470
src/code-stubs-hydrogen.cc:470:
isolate()->heap()->empty_fixed_array()));
On 2013/09/19 13:57:08, Hannes Payer wrote:
This assert can go, empty fixed array is always in old space.
Done.
https://codereview.chromium.org/23567003/diff/1/src/code-stubs-hydrogen.cc#newcode476
src/code-stubs-hydrogen.cc:476: // empty fixed array be an "immortal
immovable?"
On 2013/09/19 13:57:08, Hannes Payer wrote:
The write barrier should be skipped there by default. We can verify if
you like?
I did verify, it was there, but now I've added the empty fixed array to
the immortal immovable list, yay! So the SkipWriteBarrier is removed.
https://codereview.chromium.org/23567003/diff/4001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/23567003/diff/4001/src/code-stubs-hydrogen.cc#newcode481
src/code-stubs-hydrogen.cc:481:
isolate()->heap()->empty_fixed_array()));
On 2013/09/19 13:56:17, Michael Starzinger wrote:
nit: Let's drop this assert, see comment below.
Done.
https://codereview.chromium.org/23567003/diff/4001/src/code-stubs-hydrogen.cc#newcode488
src/code-stubs-hydrogen.cc:488: store->SkipWriteBarrier();
On 2013/09/19 13:56:17, Michael Starzinger wrote:
We should just add the empty fixed array to the list of immortal
immovable
objects and not worry about WBs here. The graph builder should not
need to think
about WBs.
Right on, done!
https://codereview.chromium.org/23567003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
