https://codereview.chromium.org/24269003/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/24269003/diff/1/src/heap.cc#newcode75
src/heap.cc:75: #if defined(ANDROID) || V8_TARGET_ARCH_MIPS
I never liked the ifdef here. Now it's time to get rid of it while you
are there. It would be great if the embedder (chrome, d8) would set the
right values. It also shouldn't be a binary decision. We have beefier
and weaker phones. Their could be arbitrary size values, depending on
the device. WDYT?
https://codereview.chromium.org/24269003/diff/1/src/heap.cc#newcode93
src/heap.cc:93: reserved_semispace_size_(DEFAULT_SEMISPACE_MAX_SIZE),
Here we could set the values to proper default values, like our default
values for non-mobile devices now.
https://codereview.chromium.org/24269003/diff/1/src/heap.cc#newcode177
src/heap.cc:177: #endif
Can you bring back this newline?
https://codereview.chromium.org/24269003/diff/1/src/heap.cc#newcode6688
src/heap.cc:6688: max_executable_size_ = DEFAULT_EXECUTABLE_MAX_SIZE /
2;
The embedder would just set the right values, no memory_constrained
guard needed.
https://codereview.chromium.org/24269003/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/24269003/diff/1/src/heap.h#newcode2342
src/heap.h:2342: bool limits_changed_from_defaults_;
Why do we need that? If the embedder decides to overwrite multiple times
that should be ok? Or is there a problem?
https://codereview.chromium.org/24269003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
