I don't think adding more #ifdefs to V8 or adding memory_constrained is the
right way to go. The core of V8 is not the best place to consolidate the
logic
for the multiple devices and configurations where it needs to run well.
Defaults
should be just that, defaults, and I really don't think they should be
device or
OS specific (at least at the V8 level) or do probing on the memory system...
then they would no longer be defaults.
I would really like to see this split up. V8 should have device independent
defaults for memory (perhaps except for 32 vs. 64 bits, where they should
double), and I am skeptical about the approach of letting embedder-specific
flags trickle into the core implementation. The embedder should specify
appropriate memory limits, but we can still make this easy by creating a
memory-defaults.cc somewhere in the source tree that is used by d8 and any
other
embedder where the collective knowledge of "the right thing to do for a
platform" with the ifdefs and platform/OS-specific probing happens to
figure out
what the overrides should be before passing them in.
https://codereview.chromium.org/24269003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
