On 2013/09/23 17:25:46, rmcilroy wrote:
As discussed this morning, I've moved this to a API call which sets device
specific heap sizes. WDYT?
I've based the code in platform-X.cc on code in chrome's base::SysInfo
class,
but I don't have the platforms available to test these - is there any way
I
can
test these on trybots for the different platforms?
Please don't spread that over all platform files. We're trying hard to get
rid
of them. Add it to platform-posix.cc (with appropriate #if's using V8_OS_*
defines) and platform-win32.cc only. Preferably you would add a SysInfo
class to
platform/sysinfo.{h,cc} that handles this (and maybe other things such as
virtual memory limits and page size in the future).
On a more general note: Is it really a good idea to base the decision on the
total physical memory? Because that number does not tell you anything in
real
life, when you have several applications resident in memory, or even several
browser tabs open at the same time.
https://chromiumcodereview.appspot.com/24269003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
