Hi Toon,
Address comments。 Thanks a lot~

https://codereview.chromium.org/24521002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/24521002/diff/1/src/hydrogen-instructions.cc#newcode1644
src/hydrogen-instructions.cc:1644: // Special handle for truncated int
multiplication with minus one.
On 2013/09/25 07:52:43, Toon Verwaest wrote:
Handle truncated integer multiplication by -1 special.

Done.

https://codereview.chromium.org/24521002/diff/1/src/hydrogen-instructions.cc#newcode2681
src/hydrogen-instructions.cc:2681: (!this->IsMul() ||
On 2013/09/25 07:52:43, Toon Verwaest wrote:
nit: indent same as sibling expression (remove the space you added)
and put both
parts of || on one line.

Done.

https://codereview.chromium.org/24521002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to