https://codereview.chromium.org/24521002/diff/6001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/24521002/diff/6001/src/hydrogen-instructions.cc#newcode1242
src/hydrogen-instructions.cc:1242: ASSERT(right().IsSmiOrInteger32());
On 2013/09/25 08:13:24, Toon Verwaest wrote:
On 2013/09/25 08:12:22, Toon Verwaest wrote:
> This should be left()->representation().IsSmiOrInteger32().
And apparently the assertion fails running the debug tests...
Done.
https://codereview.chromium.org/24521002/diff/6001/src/hydrogen-instructions.cc#newcode1242
src/hydrogen-instructions.cc:1242: ASSERT(right().IsSmiOrInteger32());
On 2013/09/25 08:12:22, Toon Verwaest wrote:
This should be left()->representation().IsSmiOrInteger32().
Done.Wired, gcc does not catch this error!
https://codereview.chromium.org/24521002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
