On 2013/09/25 08:38:41, Toon Verwaest wrote:
The ASSERT still fails in debug mode however.
Please run make check before submitting patches ;)
Sorry for that. The debug test takes a long time in my PC :(. So sometimes,
I
only run the release check. (I WILL check both in future commits).
Actually I found that the ASSERT in MulMinusOne is not necessary. The
left/right
operand could be Tagged just as the div-mul-minus-one.js test case. Now the
both
debug/release check pass.
Thanks
-Weiliang
https://codereview.chromium.org/24521002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
