https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (left):
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#oldcode517
src/heap-snapshot-generator.cc:517: CHECK_EQ(obj->Size(),
static_cast<int>(entry_info.size));
Why did you remove the size check?
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode573
src/heap-snapshot-generator.cc:573: return a->obj - b->obj;
might need a static cast on x64.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode612
src/heap-snapshot-generator.cc:612: for (int i = 0; i<
heap_objects.length(); ++i) {
nit: missing space at i<
https://codereview.chromium.org/27694004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
