https://codereview.chromium.org/27694004/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/27694004/diff/1/src/flag-definitions.h#newcode546
src/flag-definitions.h:546: DEFINE_bool(heap_profiler_trace_objects,
false,
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
May be log_heap_profiler
I think it is more precise name. Heap objects tracking is a specific
task so it definitely need a separate flag.
https://codereview.chromium.org/27694004/diff/1/src/flag-definitions.h#newcode547
src/flag-definitions.h:547: "dump heap object
allocations/movements/size_updates")
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
style: dump -> Dump
Done.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (left):
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#oldcode517
src/heap-snapshot-generator.cc:517: CHECK_EQ(obj->Size(),
static_cast<int>(entry_info.size));
On 2013/10/17 13:17:25, alph wrote:
Why did you remove the size check?
reverted
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode522
src/heap-snapshot-generator.cc:522: PrintF("Update object : %p %6d.
Next address is %p\n",
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
Next address -> End address?
We don't need to know the end address.
Usually we would like to know what would be the address of the next
object in the memory. With proposed implementation we will simple search
for an address and see the object with the address and the previous
object. It is very useful information for the allocations folding case.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode523
src/heap-snapshot-generator.cc:523: obj->address(),
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
style: wrong alignment
Done.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode548
src/heap-snapshot-generator.cc:548: bool isValid() const { return
expected_size == obj->Size(); }
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
style: IsValid
Done.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode551
src/heap-snapshot-generator.cc:551: if (expected_size == 0)
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
Please add {}.
Done.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode573
src/heap-snapshot-generator.cc:573: return a->obj - b->obj;
On 2013/10/17 13:17:25, alph wrote:
might need a static cast on x64.
It is working fine on x64 and ia32
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode591
src/heap-snapshot-generator.cc:591: if
(FLAG_heap_profiler_trace_objects)
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
Please use {}.
Done.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode602
src/heap-snapshot-generator.cc:602: untracked++;
On 2013/10/17 13:20:54, Yury Semikhatsky wrote:
untracked++ should be called if sizes don't match regardless of the
flag state.
Done.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode612
src/heap-snapshot-generator.cc:612: for (int i = 0; i<
heap_objects.length(); ++i) {
On 2013/10/17 13:17:25, alph wrote:
nit: missing space at i<
Done.
https://codereview.chromium.org/27694004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
