lgtm
https://codereview.chromium.org/27694004/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/27694004/diff/1/src/flag-definitions.h#newcode546
src/flag-definitions.h:546: DEFINE_bool(heap_profiler_trace_objects,
false,
May be log_heap_profiler
https://codereview.chromium.org/27694004/diff/1/src/flag-definitions.h#newcode547
src/flag-definitions.h:547: "dump heap object
allocations/movements/size_updates")
style: dump -> Dump
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode522
src/heap-snapshot-generator.cc:522: PrintF("Update object : %p %6d.
Next address is %p\n",
Next address -> End address?
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode523
src/heap-snapshot-generator.cc:523: obj->address(),
style: wrong alignment
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode548
src/heap-snapshot-generator.cc:548: bool isValid() const { return
expected_size == obj->Size(); }
style: IsValid
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode551
src/heap-snapshot-generator.cc:551: if (expected_size == 0)
Please add {}.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode572
src/heap-snapshot-generator.cc:572: static int comparer(const
HeapObjectInfo* a, const HeapObjectInfo* b) {
comparer -> comparator
I'd also make it a member of HeapObjectInfo.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode591
src/heap-snapshot-generator.cc:591: if
(FLAG_heap_profiler_trace_objects)
Please use {}.
https://codereview.chromium.org/27694004/diff/1/src/heap-snapshot-generator.cc#newcode602
src/heap-snapshot-generator.cc:602: untracked++;
untracked++ should be called if sizes don't match regardless of the flag
state.
https://codereview.chromium.org/27694004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
