https://codereview.chromium.org/27227005/diff/1/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):
https://codereview.chromium.org/27227005/diff/1/src/allocation-tracker.cc#newcode192
src/allocation-tracker.cc:192: printf("script->name is not a name\n");
On 2013/10/16 15:14:08, loislo wrote:
please remove this
Done.
https://codereview.chromium.org/27227005/diff/1/src/allocation-tracker.cc#newcode195
src/allocation-tracker.cc:195: // Converting start offset into line and
column may cause heap allocations.
On 2013/10/16 15:14:08, loislo wrote:
80 symbols
Done.
https://codereview.chromium.org/27227005/diff/1/src/allocation-tracker.h
File src/allocation-tracker.h (right):
https://codereview.chromium.org/27227005/diff/1/src/allocation-tracker.h#newcode35
src/allocation-tracker.h:35: class HeapObjectsMap;
On 2013/10/16 15:14:08, loislo wrote:
duplicate
Done.
https://codereview.chromium.org/27227005/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/27227005/diff/1/src/heap-snapshot-generator.cc#newcode2764
src/heap-snapshot-generator.cc:2764: EmbeddedVector<char, kBufferSize>
buffer;
On 2013/10/16 15:14:08, loislo wrote:
looks like you missed tracker check here.
The check is performed in its caller SerializeTraceTree. Also this
method doesn't use AllocationTracker, it operates on
AllocationTraceNode.
https://codereview.chromium.org/27227005/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/27227005/diff/1/test/cctest/test-heap-profiler.cc#newcode2037
test/cctest/test-heap-profiler.cc:2037: " script.push('
return f_' + i + '_' + (j+1) + '(x+1);\\n');\n"
On 2013/10/16 15:14:08, loislo wrote:
80 symbols
Done.
https://codereview.chromium.org/27227005/diff/1/test/cctest/test-heap-profiler.cc#newcode2039
test/cctest/test-heap-profiler.cc:2039: " script.push('
return new f_' + i + '_' + (depth - 1) + '();\\n');\n"
On 2013/10/16 15:14:08, loislo wrote:
80 symbols
Done.
https://codereview.chromium.org/27227005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
