LGTM, minor nits.
https://codereview.chromium.org/27227005/diff/63001/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):
https://codereview.chromium.org/27227005/diff/63001/src/allocation-tracker.cc#newcode80
src/allocation-tracker.cc:80: indent, ' ');
May fit in one line or may be more compact?
https://codereview.chromium.org/27227005/diff/63001/src/allocation-tracker.h
File src/allocation-tracker.h (right):
https://codereview.chromium.org/27227005/diff/63001/src/allocation-tracker.h#newcode127
src/allocation-tracker.h:127: static const int kMaxAllocationTraceLength
= 64;
style guide: declare static const data members before regular data
members
https://codereview.chromium.org/27227005/diff/63001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/27227005/diff/63001/src/heap-snapshot-generator.cc#newcode2761
src/heap-snapshot-generator.cc:2761: + 4 + 1 + 1;
Why don't you define this constant in the header and initialize it in
the constructor?
https://codereview.chromium.org/27227005/diff/63001/src/heap-snapshot-generator.cc#newcode2806
src/heap-snapshot-generator.cc:2806: + 6 + 1 + 1;
Same here.
https://codereview.chromium.org/27227005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
