https://codereview.chromium.org/27227005/diff/23001/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):
https://codereview.chromium.org/27227005/diff/23001/src/allocation-tracker.cc#newcode54
src/allocation-tracker.cc:54: AllocationTraceNode* node = children_[i];
On 2013/10/18 08:30:38, loislo wrote:
what are you expectations about the average number of children.
Especially in case of the highe stacks (more than 64)?
I'd expect it to be <10, if we see some nodes with a great number of
children passing some threshold we can switch to a hashmap instead of
the list. It think plain list is fine for now.
https://codereview.chromium.org/27227005/diff/23001/src/allocation-tracker.h
File src/allocation-tracker.h (right):
https://codereview.chromium.org/27227005/diff/23001/src/allocation-tracker.h#newcode101
src/allocation-tracker.h:101: AllocationTraceTree* allocation_traces() {
return &allocation_traces_; }
On 2013/10/18 08:30:38, loislo wrote:
allocation_trace_tree?
Done.
https://codereview.chromium.org/27227005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
