On 2013/10/25 06:05:06, rmcilroy wrote:
On 2013/10/25 05:47:19, Benedikt Meurer wrote:
> On 2013/10/24 21:06:56, rmcilroy wrote:
> > https://codereview.chromium.org/40233002/diff/1/include/v8-defaults.h
> > File include/v8-defaults.h (right):
> >
> >
>
https://codereview.chromium.org/40233002/diff/1/include/v8-defaults.h#newcode45
> > include/v8-defaults.h:45: uint64_t total_physical_memory);
> > On 2013/10/24 18:09:02, Benedikt Meurer wrote:
> > > There was probably some misunderstanding on our side. I thought we
settled
> on
> > > the idea of explicitly initializing a ResourceConstraints object as
> discussed
> > > with danno. We don't want to have any more global state in V8.
> > >
> > > Can you just add the explicit total_physical_memory parameter to
> > > ConfigureResourceConstraintsForCurrentPlatform() below, drop the
> > > SetDefaultResourceConstraintsForCurrentPlatform() method and do the
> following
> > in
> > > d8.cc (and similar in Blink)?
> > >
> > > ResourceConstraints constraints;
> > > if (!ConfigureResourceConstraintsForCurrentPlatform(&constraints,
> > > OS::TotalPhysicalMemory())) { Fatal... }
> > > SetResourceConstraints(isolate, &constraints);
> >
> > No, this is what I discussed with Daniel over VC and suggested in my
email.
> > Unfortunately we can't pass the total physical memory as a parameter
in
> > ConfigureResourceConstraintsForPlatform() due to the reasons I
outlined in
the
> > email thread, namely that Blink can't get the total physical memory
due to
the
> > sandbox (same problem as V8), and there is no clean way to plumb
through a
> > resource constraint object from Chrome to the isolate creation points
in
Blink
> > (especially for workers where the thread initialisation doesn't enter
Chrome
> > code).
>
> You don't need to pass the resource constraints. Just pass the total
physical
> memory (i.e. in some global variable in Blink or Chrome).
So to avoid creating a global variable in V8 I should create a global
variable
in Blink? I don't see how that is any better.
The point is: If you have to introduce hacks to make it work now, then it's
way
better to introduce the hacks on a higher level (esp. since this is issue is
caused by the inability of Blink/Chrome to properly forward the resource
constraint/total physical memory information to the appropriate place),
since
it's way easier to get rid of hacks later in a top-down fashion than in a
bottom-up fashion.
https://codereview.chromium.org/40233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
