NOT LGTM. We won't accept extremely ugly hacks in v8 to solve problems
which are
clearly on the embedder side (i.e. Blink). I understand that there is some
threading needed in Blink to get information from the
"before-the-sandbox-is-sealed" to the "after-the-sandbox-is-sealed" state,
but
this is purely are problem for Blink, and I'm quite sure that this problem
has
already solved in Blink somehow already. If not, fixing that in Blink would
be
the right approach. Abusing v8 as a kind of global state to cheat and make
some
Blink owners feel better is not the way to go. Our external API is already
ugly,
let's not make it worse...
https://codereview.chromium.org/40233002/diff/1/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/40233002/diff/1/src/d8.cc#newcode1664
src/d8.cc:1664:
ASSERT(v8::SetDefaultResourceConstraintsForCurrentPlatform());
Huh? A side effect in an assert? This is definitely not what you want...
https://codereview.chromium.org/40233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
