https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc
File src/platform/time.cc (right):
https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc#newcode292
src/platform/time.cc:292: if (clock_gettime(6 /* CLOCK_MONOTONIC_COARSE
*/, ts) == 0) {
I don't like hardcoding the constant here. Better add some
#if V8_OS_LINUX
# ifnfdef CLOCK_MONOTONIC_COARSE
# define CLOCK_MONOTONIC_COARSE 6
# endif
#endif // V8_OS_LINUX
at the beginning of the file.
https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc#newcode305
src/platform/time.cc:305: Time Time::Now() {
Time::Now() has to use gettimeofday() on POSIX systems or
CLOCK_REALTIME. It should return a Time value not a TimeTicks value.
https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc#newcode606
src/platform/time.cc:606: int result = GetBestMonotonicClock(&ts);
Please take a look at the Xorg GetTimeInMillis() function in os/utils.c.
I think we should use something similar here; can be safely inlined into
the HighResolutionNow() function, IMHO.
https://codereview.chromium.org/51333007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
