https://codereview.chromium.org/51333007/diff/120001/src/platform/time.cc
File src/platform/time.cc (right):

https://codereview.chromium.org/51333007/diff/120001/src/platform/time.cc#newcode581
src/platform/time.cc:581: static clock_t clock_id = -1;
On 2013/10/31 06:44:50, Benedikt Meurer wrote:
I think we can safely use zero here, i.e. no explicit initialization
(as Xorg
does).

I wrote it that way because 0 is a valid clock (CLOCK_REALTIME.)  I'm
fine with either though, just say the word.

https://codereview.chromium.org/51333007/diff/120001/src/platform/time.cc#newcode583
src/platform/time.cc:583: if (clock_getres(CLOCK_MONOTONIC_COARSE, &ts)
== 0 &&
On 2013/10/31 06:44:50, Benedikt Meurer wrote:
This won't compile on non-Linux systems that miss the
CLOCK_MONOTONIC_COARSE
define.

If it weren't for the #if V8_OS_LINUX a few lines up, you mean? :-)

https://codereview.chromium.org/51333007/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to