https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc
File src/platform/time.cc (right):
https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc#newcode291
src/platform/time.cc:291: if (no_clock_monotonic_coarse == false) {
On 2013/10/30 12:54:11, Sven Panne wrote:
http://refactoring.com/catalog/removeDoubleNegative.html :-)
Furthermore, using a static will introduce locking behind the scenes
IIRC, I am
not 100% sure if this is a problem here or not.
Agree on the double negative but I wrote it this way to ensure that the
flag ends up in the .bss rather than the .data section.
Not sure what you mean by locking. There is no mutex involved, if that
is what you mean. At worst, you'll have some cache line dirtying at the
start. But that's a one-time cost and it only happens when
CLOCK_MONOTONIC_COARSE is not supported.
https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc#newcode305
src/platform/time.cc:305: Time Time::Now() {
On 2013/10/30 12:49:15, Benedikt Meurer wrote:
Time::Now() has to use gettimeofday() on POSIX systems or
CLOCK_REALTIME.
You mean CLOCK_REALTIME_COARSE is not allowed? If so, why is that?
It should return a Time value not a TimeTicks value.
Not sure what you mean. Time::FromTimespec() returns a Time, right?
https://codereview.chromium.org/51333007/diff/1/src/platform/time.cc#newcode606
src/platform/time.cc:606: int result = GetBestMonotonicClock(&ts);
On 2013/10/30 12:49:15, Benedikt Meurer wrote:
Please take a look at the Xorg GetTimeInMillis() function in
os/utils.c. I think
we should use something similar here; can be safely inlined into the
HighResolutionNow() function, IMHO.
What in particular do you want to steal^Wcopy? The extra check for
CLOCK_MONOTONIC?
https://codereview.chromium.org/51333007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
