https://codereview.chromium.org/113343003/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/113343003/diff/1/src/arm/full-codegen-arm.cc#newcode3705
src/arm/full-codegen-arm.cc:3705: __ CallRuntime(Runtime::kMath_log, 1);
On 2013/12/13 13:35:39, Yang wrote:
We could directly call %Math_log from math.js and get rid of
%_Math_log. Then
again, that would mean that if Math.log is optimized by itself and not
inlined
into its caller, it would be very slow.
I came to the same conclusion (could be slow), furthermore sqrt is
handled similarly, so just changing this would be inconsistent. In a
nutshell: I think it is OK as it is in the CL, perhaps we might want to
reconsider the whole %_MathFoo story, but in a different CL.
https://codereview.chromium.org/113343003/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/113343003/diff/1/src/serialize.cc#newcode434
src/serialize.cc:434: 31,
On 2013/12/13 13:35:39, Yang wrote:
Do we want to change the numbers here now that 30 has been removed?
I think there is no need to do so. Furthermore, I'd like to clean up
things here a bit that no silly manual numbering is needed, but not in
this CL.
https://codereview.chromium.org/113343003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
