Feedback addressed, killing some dead ExternalReference stuff on the way.
Waiting for the tree to become green again after weeks of lemonish
light... :-P
https://codereview.chromium.org/113343003/diff/40001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/113343003/diff/40001/src/arm/lithium-codegen-arm.cc#newcode3939
src/arm/lithium-codegen-arm.cc:3939: __
CallCFunction(ExternalReference::math_log_double_function(isolate()),
On 2013/12/13 15:54:39, Yang wrote:
I just took a look at ExternalReference::math_log_double_function.
It refers to math_log_double whose only purpose is to wrap log, which
has the
same function signature. Are we sure the C++ compiler will inline
this? Could
this external reference directly refer to log?
Good point. Of course the compiler won't "inline", because pointers have
identity, so redirecting directly to log would be wrong. I'm directly
referring to log now.
While we're there, we can kill most of double_fp_operation, too, only
the MOD case is ever used. Furthermore, compare_doubles is dead. I think
we should thoroughly review the code in this area, there seems to be a
lot of dead code lying around...
https://codereview.chromium.org/113343003/diff/40001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):
https://codereview.chromium.org/113343003/diff/40001/src/mips/lithium-mips.cc#newcode1204
src/mips/lithium-mips.cc:1204: LOperand* input =
UseRegister(instr->value());
On 2013/12/13 15:54:39, Yang wrote:
We are not using a fixed double register anymore. Do we then get a
double
register assigned?
This seems to be the case, and it is done like this for floor, abs,
sqrt, etc.
https://codereview.chromium.org/113343003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
