LGTM if comments are addressed.
https://codereview.chromium.org/113343003/diff/40001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/113343003/diff/40001/src/arm/lithium-codegen-arm.cc#newcode3939
src/arm/lithium-codegen-arm.cc:3939: __
CallCFunction(ExternalReference::math_log_double_function(isolate()),
I just took a look at ExternalReference::math_log_double_function.
It refers to math_log_double whose only purpose is to wrap log, which
has the same function signature. Are we sure the C++ compiler will
inline this? Could this external reference directly refer to log?
https://codereview.chromium.org/113343003/diff/40001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):
https://codereview.chromium.org/113343003/diff/40001/src/mips/lithium-mips.cc#newcode1204
src/mips/lithium-mips.cc:1204: LOperand* input =
UseRegister(instr->value());
We are not using a fixed double register anymore. Do we then get a
double register assigned?
https://codereview.chromium.org/113343003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
