https://codereview.chromium.org/181063008/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/181063008/diff/1/src/mirror-debugger.js#newcode1941
src/mirror-debugger.js:1941: function ScopeMirror(frame, function,
index, opt_details) {
Maybe just "details" instead of "opt_details". "opt" is confusing, it
probably means "optional", but it can also meant "optimized" in v8. :)
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc#newcode12328
src/runtime.cc:12328: ScopeIterator it(isolate, frame,
inlined_jsframe_index);
This code seems to work, but it is fragile because it mixes handlified
code with raw pointers. ScopeIterator can cause GC, so after this point
any raw pointer to v8 heap from above may become invalid.
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc#newcode12330
src/runtime.cc:12330: MaybeObject* maybe_object =
MaterializeScopeDetails(isolate, &it);
MaterializeScopeDetails looks already handlified, it could just return a
handle, instead of maybe_objects. The you wouldn't need checks and
conversions below.
https://codereview.chromium.org/181063008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
