https://codereview.chromium.org/181063008/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc#newcode12330
src/runtime.cc:12330: MaybeObject* maybe_object =
MaterializeScopeDetails(isolate, &it);
On 2014/03/04 11:31:35, Yang wrote:
On 2014/03/04 11:04:19, aandrey wrote:
> On 2014/03/04 10:41:59, ulan wrote:
> > MaterializeScopeDetails looks already handlified, it could just
return a
> handle,
> > instead of maybe_objects. The you wouldn't need checks and
conversions
below.
>
> As far as I understand, it may return a Failure which inherits
MaybeObject and
> not Object, thus the return type is MaybeObject*.
>
> What syntax would you suggest for MaterializeScopeDetails?
I suggest changing MaterializedScopeDetails to return a
Handle<JSObject>. If the
scope_object is an empty handle, use RETURN_IF_EMPTY_HANDLE_VALUE to
propagate
that empty handle to the caller. The caller should then check with
RETURN_IF_EMPTY_HANDLE.
I know it's not actually caused by this CL, but I since we are moving
towards
less code with MaybeObject, this would be a nice small clean up.
Done.
https://codereview.chromium.org/181063008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
