https://codereview.chromium.org/181063008/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/181063008/diff/1/src/mirror-debugger.js#newcode1941
src/mirror-debugger.js:1941: function ScopeMirror(frame, function,
index, opt_details) {
On 2014/03/04 11:04:19, aandrey wrote:
On 2014/03/04 10:41:59, ulan wrote:
> Maybe just "details" instead of "opt_details". "opt" is confusing,
it probably
> means "optional", but it can also meant "optimized" in v8. :)
Yes, it means "optional", and we do use "opt_" prefix all over the
place (20+
matches in this file).
In that case it is OK.
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc#newcode12328
src/runtime.cc:12328: ScopeIterator it(isolate, frame,
inlined_jsframe_index);
You mean the JavaScriptFrame* pointer?
That pointer should be fine. This code works, but becomes confusing
because of mixing handles with maybe_object below.
https://codereview.chromium.org/181063008/diff/1/src/runtime.cc#newcode12330
src/runtime.cc:12330: MaybeObject* maybe_object =
MaterializeScopeDetails(isolate, &it);
Something like this:
Handle<Object> MaterializeScopeDetails(Isolate* isolate,
ScopeIterator* it). It could return empty handle in the case where it is
currently returning Failure, then the caller could do
Handle<Object> scope_details = MaterializeScopeDetails(isolate, &it);
RETURN_IF_EMPTY_HANDLE(isolate, scope_details);
result.Add(scope_details, isolate);
This way it is clear that all the code is handlified.
https://codereview.chromium.org/181063008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
