Nice catch. Just two suggestions.
https://codereview.chromium.org/181833004/diff/20001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/181833004/diff/20001/src/objects-visiting-inl.h#newcode936
src/objects-visiting-inl.h:936: !is_optimized_code()) {
As discussed offline: AFAICT, currently we can afford to not have the
fields overlap as the padding is big enough on 32bit and 64bit
architectures. So "un-overlapping" them woukd definitely make things
easier to read.
https://codereview.chromium.org/181833004/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/181833004/diff/20001/src/objects.h#newcode10690
src/objects.h:10690: enum WeakPointerMode {
As discussed offline: I am not a particular fan of having this mode,
because it assumes that all visitors either visit _all_ or _none_ weak
pointers and I am not sure this hold in general.
Alternatively I would suggest having a special visitor method (e.g.
VisitCodeNextPointer) that the concrete visitor can override to handle
this slot specially. This could be applied to both, the virtual as well
as the static visitor I think.
https://codereview.chromium.org/181833004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
