https://codereview.chromium.org/181833004/diff/20001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/181833004/diff/20001/src/objects-visiting-inl.h#newcode936
src/objects-visiting-inl.h:936: !is_optimized_code()) {
On 2014/03/04 12:31:12, Michael Starzinger wrote:
As discussed offline: AFAICT, currently we can afford to not have the
fields
overlap as the padding is big enough on 32bit and 64bit architectures.
So
"un-overlapping" them woukd definitely make things easier to read.
+1 unoverlap. I am sorry for overlapping them in the first place.
https://codereview.chromium.org/181833004/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/181833004/diff/20001/test/cctest/test-heap.cc#newcode3719
test/cctest/test-heap.cc:3719: TEST(NextCodeLinkIsWeak) {
Why not make a test case that creates optimized code objects and links
them together directly? This test case seems pretty brittle and makes
lots of assumptions about how the compiler links functions and code
objects together.
https://codereview.chromium.org/181833004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
