LGTM with one comment.
https://codereview.chromium.org/181833004/diff/120001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/181833004/diff/120001/src/mark-compact.cc#newcode1864
src/mark-compact.cc:1864: void VisitNextCodeLink(Object** p) { }
This should actually be unreachable, because there is no "NextCodeLink"
in the root-set. There might be code objects in the root-set, but their
body will be visited using the static visitor (see line 1882) below. Can
we add an UNREACHABLE() assertion instead?
https://codereview.chromium.org/181833004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
