Toon, do you know more about whether prototype transitions would be an
issue for
the snapshot? (See last comment)
https://codereview.chromium.org/183683022/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/183683022/diff/1/src/accessors.cc#newcode623
src/accessors.cc:623: bool is_observed =
Nit: does this fit one line now?
https://codereview.chromium.org/183683022/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/183683022/diff/1/src/ic.cc#newcode1675
src/ic.cc:1675: JSObject::cast(*object)->map()->is_observed());
Nit: does it fit previous line?
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js
File src/object-observe.js (left):
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js#oldcode28
src/object-observe.js:28: "use strict";
On 2014/03/05 00:48:46, rafaelw wrote:
it seems like all the built-in native js files are run as a single
block and so
"use strict" causes errors elsewhere.
That's surprising. The directive here should only have an effect at all
if this becomes the very first file in that block.
https://codereview.chromium.org/183683022/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/183683022/diff/1/test/cctest/test-heap.cc#newcode2007
test/cctest/test-heap.cc:2007: CompileRun("var base = {};");
On 2014/03/05 00:48:46, rafaelw wrote:
Note: the way this test was structured was asserting more than it
needed to.
Specifically it was asserting that no built in created a prototype
transition,
which struct me as a needless restriction on implementing self-hosted
code.
Sounds plausible, although you never know if there is a hidden reason in
V8. Invoking Toon, he might know more.
https://codereview.chromium.org/183683022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
