ptal
https://codereview.chromium.org/183683022/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/183683022/diff/1/src/accessors.cc#newcode623
src/accessors.cc:623: bool is_observed =
Yes. done
On 2014/03/06 08:41:35, rossberg wrote:
Nit: does this fit one line now?
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js
File src/object-observe.js (left):
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js#oldcode28
src/object-observe.js:28: "use strict";
You are right. I tried adding it back and got not failures (not sure
what I was seeing before that I thought this was happening). However, if
you're right that this directive is having no effect (or only an
effective if it's the first file), then it seems best to not have it, so
I left it out.
On 2014/03/06 08:41:35, rossberg wrote:
On 2014/03/05 00:48:46, rafaelw wrote:
> it seems like all the built-in native js files are run as a single
block and
so
> "use strict" causes errors elsewhere.
That's surprising. The directive here should only have an effect at
all if this
becomes the very first file in that block.
https://codereview.chromium.org/183683022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
