LGTM
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js
File src/object-observe.js (left):
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js#oldcode28
src/object-observe.js:28: "use strict";
On 2014/03/07 04:33:06, rafaelw wrote:
You are right. I tried adding it back and got not failures (not sure
what I was
seeing before that I thought this was happening). However, if you're
right that
this directive is having no effect (or only an effective if it's the
first
file), then it seems best to not have it, so I left it out.
Please keep it nevertheless -- we have a midterm goal of moving all JS
files to strict mode, and this serves as a marker for the ones that
already work (not too many at the moment :( ).
https://codereview.chromium.org/183683022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
