https://codereview.chromium.org/203243004/diff/20001/src/symbol.js
File src/symbol.js (right):
https://codereview.chromium.org/203243004/diff/20001/src/symbol.js#newcode100
src/symbol.js:100: throw MakeTypeError("not_a_symbol", ["Symbol.keyFor",
symbol]);
Looks like 'symbol' (%1) isn't used in the not_a_symbol format string.
https://codereview.chromium.org/203243004/diff/20001/src/symbol.js#newcode121
src/symbol.js:121: var symbolCreate = SymbolHook("@@create");
Just trying to understand.. where is the implicit addition to the global
registry for the well-known symbols given?
https://codereview.chromium.org/203243004/diff/20001/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/203243004/diff/20001/test/mjsunit/harmony/symbols.js#newcode414
test/mjsunit/harmony/symbols.js:414: assertFalse(Symbol.for("@@create")
=== Symbol.create)
Worth adding an initial test for keyFor() over well known symbols?
https://codereview.chromium.org/203243004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
