https://codereview.chromium.org/203243004/diff/50010/src/symbol.js
File src/symbol.js (right):
https://codereview.chromium.org/203243004/diff/50010/src/symbol.js#newcode68
src/symbol.js:68: if (!('internal' in registry)) {
On 2014/03/22 17:15:49, arv wrote:
Maybe this could have been
if (IS_UNDEFINED(registry.internal)) {
since the in operator is slow.
Done.
https://codereview.chromium.org/203243004/diff/50010/src/symbol.js#newcode121
src/symbol.js:121: var symbolCreate = InternalSymbol("@@create");
On 2014/03/22 17:15:49, arv wrote:
Doesn't '@' in a property name cause the object to become slow?
Objects should be completely ignorant to symbol descriptions. Am I
missing something?
The [[Description]] should be "Symbol.create".
http://people.mozilla.org/%7Ejorendorff/es6-draft.html#sec-well-known-symbols
Done.
https://codereview.chromium.org/203243004/diff/50010/src/symbol.js#newcode138
src/symbol.js:138: %SetProperty($Symbol, "create", symbolCreate,
DONT_ENUM);
On 2014/03/22 17:15:49, arv wrote:
Also, non writable, non configurable.
http://people.mozilla.org/%7Ejorendorff/es6-draft.html#sec-symbol.create
Done.
https://codereview.chromium.org/203243004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
