https://codereview.chromium.org/203243004/diff/50010/src/symbol.js
File src/symbol.js (right):
https://codereview.chromium.org/203243004/diff/50010/src/symbol.js#newcode121
src/symbol.js:121: var symbolCreate = InternalSymbol("@@create");
On 2014/03/24 15:18:57, arv wrote:
On 2014/03/24 10:25:53, rossberg wrote:
> On 2014/03/22 17:15:49, arv wrote:
> > Doesn't '@' in a property name cause the object to become slow?
>
> Objects should be completely ignorant to symbol descriptions. Am I
missing
> something?
>
> > The [[Description]] should be "Symbol.create".
> >
> >
http://people.mozilla.org/%25257Ejorendorff/es6-draft.html#sec-well-known-symbols
>
> Done.
You use the key on line 80. If we have a non identifier key we end up
with a
slow object instead of an object with a hidden class for
registry.internal.
However, I doubt this is an issue since the calls to InternalSymbol is
limited.
You're right. The dot will have the same effect, though.
But: I don't think it's an issue, quite the opposite -- this object is
meant to be a dictionary. It would actually be preferable to force this
and the other objects to be in dictionary mode from the get-go, to avoid
unnecessary transitions and polymorphism. I'll add that to the other CL.
https://codereview.chromium.org/203243004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
