Some more comments. Getting there. I especially like the fullcodegen
cleanup.
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2456
src/ia32/code-stubs-ia32.cc:2456: if (attributes ==
CallIC::NOT_STRICT_OR_NATIVE) {
CallIC::SLOPPY
Seems like in this case you don't need the checks above.
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2469
src/ia32/code-stubs-ia32.cc:2469: if (argument_check ==
CallIC::ARGUMENTS_MATCH) {
ARGUMENTS_MUST_MATCH, to distinguish from the other case,
ARGUMENTS_COUNT_UNKNOWN
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2527
src/ia32/code-stubs-ia32.cc:2527: __ mov(ecx, FieldOperand(ebx, edx,
times_half_pointer_size,
__ cmp(edi, Field...
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2532
src/ia32/code-stubs-ia32.cc:2532: if (stub_type() !=
CallIC::MONOMORPHIC) {
stub_type() == CallIC::DEFAULT_MONOMORPHIC
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2535
src/ia32/code-stubs-ia32.cc:2535: CallIC::ARGUMENTS_MATCH,
Can we merge this with the non-default case by just setting up
argument_check() and function_attributes() correctly for the default
case?
https://codereview.chromium.org/172523002/diff/280001/src/ia32/code-stubs-ia32.cc#newcode2536
src/ia32/code-stubs-ia32.cc:2536: CallIC::NOT_STRICT_OR_NATIVE);
CallIC::default_strict_or_native() {
return argument_check() == ARGUMENTS_MATCH && function_attributes() ==
CallIC::SLOPPY;
}
https://codereview.chromium.org/172523002/diff/280001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/172523002/diff/280001/src/ic.cc#newcode1836
src/ic.cc:1836: return;
Patch in the generic case, which doesn't record anymore, but also
doesn't check.
https://codereview.chromium.org/172523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
