Thanks Toon, nits and ports addressed.
I did find a bug: with incremental marking, we might clear ICs in a code
object
without also clearing type cells. I fixed this with a change in
SharedFunctionInfo::ResetForNewContext().
Will do some perf jobs, etc., before final submit.
--Michael
https://codereview.chromium.org/172523002/diff/300001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/172523002/diff/300001/src/code-stubs.h#newcode842
src/code-stubs.h:842: return state_.IsSloppyOrNonNative();
On 2014/03/27 16:02:25, Toon Verwaest wrote:
IsSloppyNonNative()
It's and, not or.
That, or IsStrictOrNative()
Done.
https://codereview.chromium.org/172523002/diff/300001/src/code-stubs.h#newcode1671
src/code-stubs.h:1671: }
On 2014/03/27 16:02:25, Toon Verwaest wrote:
Spurious change
Done.
https://codereview.chromium.org/172523002/diff/300001/src/ia32/debug-ia32.cc
File src/ia32/debug-ia32.cc (right):
https://codereview.chromium.org/172523002/diff/300001/src/ia32/debug-ia32.cc#newcode208
src/ia32/debug-ia32.cc:208: // TODO(mvstanton): should eax be saved,
non-object reg?
On 2014/03/27 16:02:25, Toon Verwaest wrote:
So?
Right, no need for that, I had some confusion with CallConstructStub
which does need eax saved.
https://codereview.chromium.org/172523002/diff/300001/src/ic.h
File src/ic.h (right):
https://codereview.chromium.org/172523002/diff/300001/src/ic.h#newcode314
src/ic.h:314: enum FunctionAttributes { SLOPPY_OR_NONNATIVE,
STRICT_OR_NATIVE };
On 2014/03/27 16:02:25, Toon Verwaest wrote:
SLOPPY_NONNATIVE
Done.
https://codereview.chromium.org/172523002/diff/300001/src/ic.h#newcode395
src/ic.h:395: class ArgBits: public BitField<int, 0,
Code::kArgumentsBits> {};
On 2014/03/27 16:02:25, Toon Verwaest wrote:
Arg or ArgcBits? Just make sure it's consistent everywhere.
Done, I went with ArgcBits.
https://codereview.chromium.org/172523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
