LGTM, go ahead with the ports.
Just some minor nits.
https://codereview.chromium.org/172523002/diff/300001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/172523002/diff/300001/src/code-stubs.h#newcode842
src/code-stubs.h:842: return state_.IsSloppyOrNonNative();
IsSloppyNonNative()
It's and, not or.
That, or IsStrictOrNative()
https://codereview.chromium.org/172523002/diff/300001/src/code-stubs.h#newcode1671
src/code-stubs.h:1671: }
Spurious change
https://codereview.chromium.org/172523002/diff/300001/src/ia32/debug-ia32.cc
File src/ia32/debug-ia32.cc (right):
https://codereview.chromium.org/172523002/diff/300001/src/ia32/debug-ia32.cc#newcode208
src/ia32/debug-ia32.cc:208: // TODO(mvstanton): should eax be saved,
non-object reg?
So?
https://codereview.chromium.org/172523002/diff/300001/src/ic.h
File src/ic.h (right):
https://codereview.chromium.org/172523002/diff/300001/src/ic.h#newcode314
src/ic.h:314: enum FunctionAttributes { SLOPPY_OR_NONNATIVE,
STRICT_OR_NATIVE };
SLOPPY_NONNATIVE
https://codereview.chromium.org/172523002/diff/300001/src/ic.h#newcode395
src/ic.h:395: class ArgBits: public BitField<int, 0,
Code::kArgumentsBits> {};
Arg or ArgcBits? Just make sure it's consistent everywhere.
https://codereview.chromium.org/172523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
