lgtm with comments
https://codereview.chromium.org/209323014/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/209323014/diff/1/include/v8.h#newcode4959
include/v8.h:4959: * of the data file as to be passed.
has to be provided
https://codereview.chromium.org/209323014/diff/1/src/icu_util.cc
File src/icu_util.cc (right):
https://codereview.chromium.org/209323014/diff/1/src/icu_util.cc#newcode82
src/icu_util.cc:82: delete[] addr;
Not sure if we care about deleting this on V8 cleanup, valgrind might
complain.
https://codereview.chromium.org/209323014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
