Again a bit late, but...
https://codereview.chromium.org/209323014/diff/1/src/icu_util.cc
File src/icu_util.cc (right):
https://codereview.chromium.org/209323014/diff/1/src/icu_util.cc#newcode82
src/icu_util.cc:82: delete[] addr;
On 2014/03/25 12:04:11, jochen wrote:
On 2014/03/25 08:47:21, danno wrote:
> Not sure if we care about deleting this on V8 cleanup, valgrind
might
complain.
I don't think we run d8 when build in chromium under valgrind. And if
yes, we
need to add a suppression to valgrind.
Hmmm, d8 should really be valgrind-clean, and it was (at least at some
points in the past ;-). If this CL breaks this, we should add some kind
of cleanup call like DeinitializeICU().
https://codereview.chromium.org/209323014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
