On 2014/03/26 05:53:14, Jungshik Shin wrote:
This is also late, but I'm just wondering about mmap.

https://codereview.chromium.org/209323014/diff/1/src/icu_util.cc
File src/icu_util.cc (right):

https://codereview.chromium.org/209323014/diff/1/src/icu_util.cc#newcode81
src/icu_util.cc:81: if (fread(addr, 1, size, inf) != size) {
Would it be a good idea to use memory map (I saw some utilities functions in
v8
tree for mmap) instead?

there's just support for mmaping anonymous memory.

also, this code is only used for testing, so I don't think it needs to be too
fancy

https://codereview.chromium.org/209323014/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to